mobi/seedvault
1
0
Fork 0
Code Pull requests Activity

UNTESTED: Don't backup device or profile owner apps

Browse source
This commit is contained in:
Torsten Grote 2024-02-12 11:10:27 -03:00
parent 9c4f9d8a67
commit eefeb7607d
No known key found for this signature in database
GPG key ID: 3E5F77D92CF891FF
1 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
app/src/main/java/com/stevesoltys/seedvault/transport/backup/PackageService.kt
View file

@ -1,5 +1,6 @@
package com.stevesoltys.seedvault.transport.backup package com.stevesoltys.seedvault.transport.backup
import android.app.admin.DevicePolicyManager
import android.app.backup.IBackupManager import android.app.backup.IBackupManager
import android.content.Context import android.content.Context
import android.content.pm.ApplicationInfo.FLAG_ALLOW_BACKUP import android.content.pm.ApplicationInfo.FLAG_ALLOW_BACKUP
@ -36,6 +37,7 @@ internal class PackageService(
) { ) {
private val packageManager: PackageManager = context.packageManager private val packageManager: PackageManager = context.packageManager
private val devicePolicyManager = context.getSystemService(DevicePolicyManager::class.java)
private val myUserId = UserHandle.myUserId() private val myUserId = UserHandle.myUserId()
val eligiblePackages: Array<String> val eligiblePackages: Array<String>
@ -156,6 +158,10 @@ internal class PackageService(
// Check that the app is not excluded by user preference // Check that the app is not excluded by user preference
val enabled = settingsManager.isBackupEnabled(packageName) val enabled = settingsManager.isBackupEnabled(packageName)
// restoring device or profiler owners will cause things to crash
if (devicePolicyManager.isDeviceOwnerApp(packageName) ||
devicePolicyManager.isProfileOwnerApp(packageName)) return false
// We need to explicitly exclude DocumentsProvider and Seedvault. // We need to explicitly exclude DocumentsProvider and Seedvault.
// Otherwise, they get killed while backing them up, terminating our backup. // Otherwise, they get killed while backing them up, terminating our backup.
val excludedPackages = setOf( val excludedPackages = setOf(
@ -201,6 +207,8 @@ internal class PackageService(
*/ */
private fun PackageInfo.doesNotGetBackedUp(): Boolean { private fun PackageInfo.doesNotGetBackedUp(): Boolean {
if (packageName == MAGIC_PACKAGE_MANAGER || applicationInfo == null) return true if (packageName == MAGIC_PACKAGE_MANAGER || applicationInfo == null) return true
if (isSystemApp() && (devicePolicyManager.isDeviceOwnerApp(packageName) ||
devicePolicyManager.isProfileOwnerApp(packageName))) return true
return !allowsBackup() || isStopped() return !allowsBackup() || isStopped()
} }
} }