mobi/seedvault
1
0
Fork 0
Code Pull requests Activity

Stop cleaning up notification when service is destroyed.

Browse source
This commit is contained in:
Torsten Grote 2024-02-06 13:50:28 -03:00
parent 4014666c15
commit b47b4ade1e
No known key found for this signature in database
GPG key ID: 3E5F77D92CF891FF
1 changed files with 11 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
app/src/main/java/com/stevesoltys/seedvault/ui/notification/BackupNotificationManager.kt
View file

@ -184,13 +184,17 @@ internal class BackupNotificationManager(private val context: Context) {
//
// This won't bring back the expected finish notification in this case,
// but at least we don't leave stuck notifications laying around.
nm.activeNotifications.forEach { notification ->
// only consider ongoing notifications in our ID space (storage backup uses > 1000)
if (notification.isOngoing && notification.id < 1000) {
Log.w(TAG, "Needed to clean up notification with ID ${notification.id}")
nm.cancel(notification.id)
}
}
// FIXME the service gets destroyed for each chunk when requesting backup in chunks
// This leads to the cancellation of an ongoing backup notification.
// So for now, we'll remove automatic notification clean-up
// and find out if it is still necessary. If not, this comment can be removed.
// nm.activeNotifications.forEach { notification ->
// // only consider ongoing notifications in our ID space (storage backup uses > 1000)
// if (notification.isOngoing && notification.id < 1000) {
// Log.w(TAG, "Needed to clean up notification with ID ${notification.id}")
// nm.cancel(notification.id)
// }
// }
}
fun onBackupFinished(success: Boolean, numBackedUp: Int?, size: Long) {