From 803acf7fa15b32f69dbae8d41942aa4a4299f318 Mon Sep 17 00:00:00 2001
From: Chirayu Desai <chirayudesai1@gmail.com>
Date: Sat, 15 Oct 2022 00:16:06 +0530
Subject: [PATCH] Mark Nextcloud as not recommended

* We've had a love/hate relationship with the combination of
  SAF + Nextcloud app + Nextcloud server
* SAF is quite limiting, and that causes it's own issues
* On top of that, Nextcloud app has it's own issues. We've
  even sent patches for some things, but there's only so much one can do
  https://github.com/nextcloud/android/pulls?q=is%3Apr+author%3Agrote
* With the DAVx5 WebDAV support, it seems to work better.
* However, most recently a server side change broke things entirely, with either apps
  https://github.com/seedvault-app/seedvault/issues/490#issuecomment-1368032414
* Due of all of this, it just leads to a bad backup experience.
  As such, let's just say this is not recommended at all entirely
* Hopefully in the future we'll be able to support more options

Change-Id: I0b46dd11df7c31606131bf311583fe4777536463
---
 .../com/stevesoltys/seedvault/ui/storage/SafStorageOptions.kt  | 3 ++-
 app/src/main/res/values/strings.xml                            | 1 +
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/app/src/main/java/com/stevesoltys/seedvault/ui/storage/SafStorageOptions.kt b/app/src/main/java/com/stevesoltys/seedvault/ui/storage/SafStorageOptions.kt
index c0140b2a..f3e9ba6b 100644
--- a/app/src/main/java/com/stevesoltys/seedvault/ui/storage/SafStorageOptions.kt
+++ b/app/src/main/java/com/stevesoltys/seedvault/ui/storage/SafStorageOptions.kt
@@ -136,7 +136,8 @@ internal class SafStorageOptions(
             rootId = "fake",
             documentId = "fake",
             icon = getIcon(context, AUTHORITY_NEXTCLOUD, "fake", 0),
-            title = context.getString(R.string.storage_fake_nextcloud_title),
+            title = context.getString(R.string.storage_not_recommended,
+                context.getString(R.string.storage_fake_nextcloud_title)),
             summary = context.getString(summaryRes),
             availableBytes = null,
             isUsb = false,
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index b4976db9..fbad772b 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -58,6 +58,7 @@
     <string name="storage_fake_drive_title">USB flash drive</string>
     <string name="storage_fake_drive_summary">Needs to be plugged in</string>
     <string name="storage_available_bytes"><xliff:g example="1 GB" id="size">%1$s</xliff:g> free</string>
+    <string name="storage_not_recommended"><xliff:g example="Skynet">%1$s</xliff:g> (Not recommended)</string>
     <string name="storage_fake_nextcloud_title" translatable="false">Nextcloud</string>
     <string name="storage_fake_nextcloud_summary">Tap to install</string>
     <string name="storage_fake_nextcloud_summary_installed">Tap to set up account</string>