From 6d580e2320c71f1c691a4c7fde44f1fde575407e Mon Sep 17 00:00:00 2001 From: Torsten Grote Date: Tue, 4 Jun 2019 17:45:21 -0300 Subject: [PATCH] Use Android's logging instead of printing stacktraces to STDERR --- .../backup/activity/MainActivityController.java | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/com/stevesoltys/backup/activity/MainActivityController.java b/app/src/main/java/com/stevesoltys/backup/activity/MainActivityController.java index 55f67624..c92ba84d 100644 --- a/app/src/main/java/com/stevesoltys/backup/activity/MainActivityController.java +++ b/app/src/main/java/com/stevesoltys/backup/activity/MainActivityController.java @@ -5,6 +5,7 @@ import android.content.ActivityNotFoundException; import android.content.ContentResolver; import android.content.Intent; import android.net.Uri; +import android.util.Log; import android.widget.Toast; import com.stevesoltys.backup.activity.backup.CreateBackupActivity; @@ -35,6 +36,8 @@ import static com.stevesoltys.backup.settings.SettingsManager.setBackupFolderUri */ class MainActivityController { + private static final String TAG = MainActivityController.class.getName(); + private static final String DOCUMENT_MIME_TYPE = "application/octet-stream"; private static final String DOCUMENT_SUFFIX = "yyyy-MM-dd_HH_mm_ss"; @@ -48,7 +51,7 @@ class MainActivityController { showCreateBackupActivity(parent, fileUri); } catch (IOException e) { - e.printStackTrace(); + Log.w(TAG, "Error creating backup file: ", e); showChooseFolderActivity(parent, true); } } @@ -117,9 +120,9 @@ class MainActivityController { showCreateBackupActivity(parent, fileUri); } catch (IOException e) { + Log.e(TAG, "Error creating backup file: ", e); // TODO show better error message once more infrastructure is in place Toast.makeText(parent, "Error creating backup file", Toast.LENGTH_SHORT).show(); - e.printStackTrace(); } }