mobi/e-ntfy-android
1
0
Fork 0
Code Pull requests Activity

Prevent view action from crashing the app, fixes #233

Browse source
This commit is contained in:
Philipp Heckel 2022-05-03 19:38:52 -04:00
parent 821a1ac222
commit fc11a5079f
2 changed files with 9 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/src/main/java/io/heckel/ntfy/ui/DetailAdapter.kt
View file

@ -433,11 +433,15 @@ class DetailAdapter(private val activity: Activity, private val lifecycleScope:
} }
private fun runViewAction(context: Context, action: Action) { private fun runViewAction(context: Context, action: Action) {
try {
val url = action.url ?: return val url = action.url ?: return
val intent = Intent(Intent.ACTION_VIEW, Uri.parse(url)).apply { val intent = Intent(Intent.ACTION_VIEW, Uri.parse(url)).apply {
addFlags(Intent.FLAG_GRANT_READ_URI_PERMISSION) addFlags(Intent.FLAG_GRANT_READ_URI_PERMISSION)
} }
context.startActivity(intent) context.startActivity(intent)
} catch (e: Exception) {
Log.w(TAG, "Unable to start activity from URL ${action.url}", e)
}
} }
private fun runOtherUserAction(context: Context, notification: Notification, action: Action) { private fun runOtherUserAction(context: Context, notification: Notification, action: Action) {

1
fastlane/metadata/android/en-US/changelog/27.txt
View file

@ -7,6 +7,7 @@ Bugs:
* Restoring topics or settings from backup doesn't work (#223, thanks to @shadow00 for reporting) * Restoring topics or settings from backup doesn't work (#223, thanks to @shadow00 for reporting)
* Fix app icon on old Android versions (#120, thanks to @shadow00 for reporting) * Fix app icon on old Android versions (#120, thanks to @shadow00 for reporting)
* Fix races in UnifiedPush registration (#230, thanks to @Jakob for reporting) * Fix races in UnifiedPush registration (#230, thanks to @Jakob for reporting)
* Prevent view action from crashing the app (#233)
**Thanks for testing:** **Thanks for testing:**