ynh-lydra-ansible-yunohost/tasks/domains.yml

---
- name: List currently installed domains
  ansible.builtin.command: yunohost domain list --output-as json
  register: ynh_installed_domains_raw
  changed_when: False

- name: Format json of domains
  ansible.builtin.set_fact: ynh_installed_domains="{{ ynh_installed_domains_raw.stdout | from_json }}"

- name: Create domains
  ansible.builtin.command: yunohost domain add {{ item }}
  with_items: "{{ ynh_extra_domains }}"
  when: item not in ynh_installed_domains.domains
Refactor app managment, add domains 2017-08-24 22:39:58 +02:00			`---`
			`- name: List currently installed domains`
♻refactor: Command ansible module across the repo for better security Shell module is not needed here. According to various sources (https://www.youtube.com/watch?v=57gAqKvAKck or https://stackoverflow.com/questions/56663332/difference-between-shell-and-command-in-ansible) it is not useful to use shell ansible module when not working with operands. Therefore I have decided to switch every actions to command module, more secure. Ansible-lint says "Shell should only be used when piping, redirecting or chaining commands" 2021-10-12 16:00:56 +02:00			`ansible.builtin.command: yunohost domain list --output-as json`
refactor: changed vars to reflect new variable names refactor: changed variables pattern to be more consistent with ansible good practises and more flexible to use. refactor: remove useless comment doc: Readme in English and French 2021-10-12 14:27:37 +02:00			`register: ynh_installed_domains_raw`
Refactor app managment, add domains 2017-08-24 22:39:58 +02:00			`changed_when: False`

			`- name: Format json of domains`
refactor: changed vars to reflect new variable names refactor: changed variables pattern to be more consistent with ansible good practises and more flexible to use. refactor: remove useless comment doc: Readme in English and French 2021-10-12 14:27:37 +02:00			`ansible.builtin.set_fact: ynh_installed_domains="{{ ynh_installed_domains_raw.stdout \| from_json }}"`
Refactor app managment, add domains 2017-08-24 22:39:58 +02:00
			`- name: Create domains`
♻refactor: Command ansible module across the repo for better security Shell module is not needed here. According to various sources (https://www.youtube.com/watch?v=57gAqKvAKck or https://stackoverflow.com/questions/56663332/difference-between-shell-and-command-in-ansible) it is not useful to use shell ansible module when not working with operands. Therefore I have decided to switch every actions to command module, more secure. Ansible-lint says "Shell should only be used when piping, redirecting or chaining commands" 2021-10-12 16:00:56 +02:00			`ansible.builtin.command: yunohost domain add {{ item }}`
refactor: changed vars to reflect new variable names refactor: changed variables pattern to be more consistent with ansible good practises and more flexible to use. refactor: remove useless comment doc: Readme in English and French 2021-10-12 14:27:37 +02:00			`with_items: "{{ ynh_extra_domains }}"`
			`when: item not in ynh_installed_domains.domains`