hosting/ynh-apps_tools
1
0
Fork 0
Code Activity

Implement an app rejection list (#2515)

Browse source 
Co-authored-by: Alexandre Aubin <alex.aubin@mailoo.org>
Co-authored-by: OniriCorpe <oniricorpe@yunohost.org>
This commit is contained in:
tituspijean 2024-08-18 01:52:37 +02:00 committed by GitHub
parent 5ef9e66b3a
commit b06f909c9d
1 changed files with 102 additions and 43 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

59
webhooks/webhook.py
View file

@ -10,6 +10,7 @@ import tempfile
import aiohttp
import logging
from pathlib import Path
import re
from typing import Optional
from git import Actor, Repo, GitCommandError
@ -116,6 +117,8 @@ def on_push(request: Request) -> HTTPResponse:
repository = data["repository"]["full_name"]
branch = data["ref"].split("/", 2)[2]
if repository.startswith("YunoHost-Apps/"):
logging.info(f"{repository} -> branch '{branch}'")
need_push = False
@ -149,11 +152,23 @@ def on_pr_comment(request: Request, pr_infos: dict) -> HTTPResponse:
body = request.json["comment"]["body"].strip()[:100].lower()
# Check the comment contains proper keyword trigger
BUMP_REV_COMMANDS = ["!bump", "!new_revision", "!newrevision"]
if any(trigger.lower() in body for trigger in BUMP_REV_COMMANDS):
bump_revision(request, pr_infos)
return response.text("ok")
REJECT_WISHLIST_COMMANDS = ["!reject", "!nope"]
if any(trigger.lower() in body for trigger in REJECT_WISHLIST_COMMANDS):
reason = ""
for command in REJECT_WISHLIST_COMMANDS:
try:
reason = re.search(f"{command} (.*)", body).group(1).rstrip()
except:
pass
reject_wishlist(request, pr_infos, reason)
return response.text("ok")
return response.empty()
@ -162,6 +177,8 @@ def bump_revision(request: Request, pr_infos: dict) -> HTTPResponse:
repository = data["repository"]["full_name"]
branch = pr_infos["head"]["ref"]
if repository.startswith("YunoHost-Apps/"):
logging.info(f"Will bump revision on {repository} branch {branch}...")
with tempfile.TemporaryDirectory() as folder_str:
folder = Path(folder_str)
@ -188,6 +205,48 @@ def bump_revision(request: Request, pr_infos: dict) -> HTTPResponse:
repo.remote().push(quiet=False, all=True)
return response.text("ok")
def reject_wishlist(request: Request, pr_infos: dict, reason=None) -> HTTPResponse:
data = request.json
repository = data["repository"]["full_name"]
branch = pr_infos["head"]["ref"]
if repository == "YunoHost/apps" and branch.startswith("add-to-wishlist"):
logging.info(f"Will put the suggested app in the rejected list on {repository} branch {branch}...")
with tempfile.TemporaryDirectory() as folder_str:
folder = Path(folder_str)
repo = Repo.clone_from(
f"https://{github_login()}:{github_token()}@github.com/{repository}",
to_path=folder,
)
repo.git.checkout(branch)
rejectedlist_file = (folder / "rejectedlist.toml")
rejectedlist = tomlkit.load(rejectedlist_file.open("r", encoding="utf-8"))
wishlist_file = (folder / "wishlist.toml")
wishlist = tomlkit.load(wishlist_file.open("r", encoding="utf-8"))
suggestedapp_slug = branch.replace("add-to-wishlist-", "")
suggestedapp = {suggestedapp_slug:wishlist[suggestedapp_slug]}
suggestedapp[suggestedapp_slug]["rejection_pr"] = pr_infos["html_url"]
suggestedapp[suggestedapp_slug]["reason"] = reason
wishlist.pop(suggestedapp_slug)
rejectedlist.update(suggestedapp)
tomlkit.dump(rejectedlist, rejectedlist_file.open("w", encoding="utf-8"))
tomlkit.dump(wishlist, wishlist_file.open("w", encoding="utf-8"))
repo.git.add("rejectedlist.toml")
repo.git.add("wishlist.toml")
suggestedapp_name = suggestedapp[suggestedapp_slug]["name"]
repo.index.commit(f"Reject {suggestedapp_name} from catalog", author=Actor("yunohost-bot", "yunohost@yunohost.org"))
logging.debug(f"Pushing {repository}")
repo.remote().push(quiet=False, all=True, force=True)
return response.text("ok")
def generate_and_commit_readmes(repo: Repo) -> bool:
assert repo.working_tree_dir is not None