From 581d227bd3783843d86fc219a32e72e5511cb95e Mon Sep 17 00:00:00 2001 From: Alexandre Aubin Date: Sun, 27 Nov 2022 16:39:49 +0100 Subject: [PATCH] convert_app_to_packaging_v2: add explanation on the meaning of the ldap and sso keys --- packaging_v2/convert_app_to_packaging_v2.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packaging_v2/convert_app_to_packaging_v2.py b/packaging_v2/convert_app_to_packaging_v2.py index 4d6d97a..6c98cff 100644 --- a/packaging_v2/convert_app_to_packaging_v2.py +++ b/packaging_v2/convert_app_to_packaging_v2.py @@ -168,9 +168,9 @@ def _dump_v2_manifest_as_toml(manifest): integration = table() for key, value in manifest["integration"].items(): integration.add(key, value) - integration["architectures"].comment('FIXME: can be replaced by a list of supported archs using the dpkg --print-architecture nomenclature (amd64/i386/armhf/arm64/armel), for example: ["amd64", "i386"]') - integration["ldap"].comment('FIXME: replace with true, false, or "not_relevant"') - integration["sso"].comment('FIXME: replace with true, false, or "not_relevant"') + integration["architectures"].comment('FIXME: can be replaced by a list of supported archs using the dpkg --print-architecture nomenclature (amd64/i386/armhf/arm64), for example: ["amd64", "i386"]') + integration["ldap"].comment('FIXME: replace with true, false, or "not_relevant". Not to confuse with the "sso" key : the "ldap" key corresponds to wether or not a user *can* login on the app using its YunoHost credentials.') + integration["sso"].comment('FIXME: replace with true, false, or "not_relevant". Not to confuse with the "ldap" key : the "sso" key corresponds to wether or not a user is *automatically logged-in* on the app when logged-in on the YunoHost portal.') integration["disk"].comment('FIXME: replace with an **estimate** minimum disk requirement. e.g. 20M, 400M, 1G, ...') integration["ram.build"].comment('FIXME: replace with an **estimate** minimum ram requirement. e.g. 50M, 400M, 1G, ...') integration["ram.runtime"].comment('FIXME: replace with an **estimate** minimum ram requirement. e.g. 50M, 400M, 1G, ...')