hosting/ynh-apps_tools
1
0
Fork 0
Code Activity

Fix regex to replace version in manifest

Browse source 
This regex is used to find (textually, not via toml parser) where to replace the
version number in the Manifest.

Until now it was only supporting version numbers containing dots and digits.
I changed that to version numbers containing anything but ~ and " to handle version
numbers with dashes, or manually written version numbers that might be invalid (if
someone litteraly writes `version = "x.y~ynh1"). We don’t actually care about the
version number we match against because we just replace it.
This commit is contained in:
Félix Piédallu 2024-03-06 23:10:48 +01:00 committed by Bram
parent 78e5e21deb
commit 48c41dad9b
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
autoupdate_app_sources/autoupdate_app_sources.py
View file

@ -480,7 +480,7 @@ class AppAutoUpdater:
if is_main: if is_main:
def repl(m: re.Match) -> str: def repl(m: re.Match) -> str:
return m.group(1) + new_version + '~ynh1"' return m.group(1) + new_version + '~ynh1"'
content = re.sub(r"(\s*version\s*=\s*[\"\'])([\d\.]+)(\~ynh\d+[\"\'])", repl, content) content = re.sub(r"(\s*version\s*=\s*[\"\'])([^~\"\']+)(\~ynh\d+[\"\'])", repl, content)
for old, new in replacements: for old, new in replacements:
content = content.replace(old, new) content = content.replace(old, new)