From 021c465fd6cc6eb9cc57046d1ac6eefc1ba34fd5 Mon Sep 17 00:00:00 2001
From: ibizaman <ibizapeanut@gmail.com>
Date: Fri, 5 Jan 2024 15:17:53 -0800
Subject: [PATCH] make onlyoffice config a bit nicer

---
 modules/services/nextcloud-server.nix | 24 ++++++++++++++++++++----
 1 file changed, 20 insertions(+), 4 deletions(-)

diff --git a/modules/services/nextcloud-server.nix b/modules/services/nextcloud-server.nix
index 0d6d985..bc72bd3 100644
--- a/modules/services/nextcloud-server.nix
+++ b/modules/services/nextcloud-server.nix
@@ -113,14 +113,23 @@ in
       description = ''
         Applications to enable in Nextcloud. Enabling an application here will also configure
         various services needed for this application.
+
+        Enabled apps will automatically be installed, enabled and configured, so no need to do that
+        through the UI. You can still make changes but they will be overridden on next deploy. You
+        can still install and configure other apps through the UI.
       '';
       type = lib.types.submodule {
         options = {
           onlyoffice = lib.mkOption {
             description = "If non null, set up an Only Office service.";
-            default = null;
-            type = lib.types.nullOr (lib.types.submodule {
+            default = {
+              enable = false;
+              jwtSecretFile = "";
+            };
+            type = lib.types.submodule {
               options = {
+                enable = lib.mkEnableOption "Nextcloud OnlyOffice App";
+
                 subdomain = lib.mkOption {
                   type = lib.types.str;
                   description = "Subdomain under which Only Office will be served.";
@@ -130,7 +139,7 @@ in
                 localNetworkIPRange = lib.mkOption {
                   type = lib.types.str;
                   description = "Local network range, to restrict access to Open Office to only those IPs.";
-                  example = "192.168.1.1/24";
+                  default = "192.168.1.1/24";
                 };
 
                 jwtSecretFile = lib.mkOption {
@@ -344,7 +353,14 @@ in
       };
     })
 
-    (lib.mkIf (!(isNull cfg.apps.onlyoffice)) {
+    (lib.mkIf cfg.apps.onlyoffice.enable {
+      assertions = [
+        {
+          assertion = cfg.apps.onlyoffice.jwtSecretFile != "";
+          message = "Must set jwtSecretFile.";
+        }
+      ];
+
       services.nextcloud.extraApps = {
         inherit (nextcloudApps) onlyoffice;
       };