From d04f1612037f61dd62a6576889dca024e6233e54 Mon Sep 17 00:00:00 2001
From: Pere Lev <pere@towards.vision>
Date: Mon, 29 Apr 2024 01:14:56 +0300
Subject: [PATCH] UI, Client: Move invite-component form to ProjectComponentsR
 and use getCapability

---
 src/Vervis/Handler/Project.hs          | 36 +++++++++++---------------
 src/Vervis/Widget/Person.hs            |  4 +--
 templates/project/component-new.hamlet | 18 -------------
 templates/project/components.hamlet    | 11 +++++---
 th/routes                              |  2 +-
 5 files changed, 26 insertions(+), 45 deletions(-)
 delete mode 100644 templates/project/component-new.hamlet

diff --git a/src/Vervis/Handler/Project.hs b/src/Vervis/Handler/Project.hs
index cf10fb0..9c503c3 100644
--- a/src/Vervis/Handler/Project.hs
+++ b/src/Vervis/Handler/Project.hs
@@ -38,7 +38,6 @@ module Vervis.Handler.Project
     , getProjectComponentsR
     , getProjectCollabLiveR
 
-    , getProjectInviteCompR
     , postProjectInviteCompR
 
     , getProjectChildrenR
@@ -484,6 +483,12 @@ getProjectComponentsR projectHash = do
             return (i E.^. InstanceHost, ro E.^. RemoteObjectIdent)
 
     getHtml projectID = do
+        mp <- maybeAuthId
+        haveAdmin <- fmap isJust $ handlerToWidget $ runDB $ runMaybeT $ do
+            personID <- MaybeT $ pure mp
+            project <- lift $ get404 projectID
+            MaybeT $ getCapability personID (Left $ projectResource project) AP.RoleAdmin
+        ((_, widgetIC), enctypeIC) <- handlerToWidget $ runFormPost projectInviteCompForm
         (project, actor, comps, drafts) <- handlerToWidget $ runDB $ do
             project <- get404 projectID
             actor <- getJust $ projectActor project
@@ -556,12 +561,6 @@ getProjectCollabLiveR projectHash enableHash = do
         Collab _ resourceID' <- getJust collabID
         unless (resourceID == resourceID') notFound
 
-getProjectInviteCompR :: KeyHashid Project -> Handler Html
-getProjectInviteCompR projectHash = do
-    projectID <- decodeKeyHashid404 projectHash
-    ((_result, widget), enctype) <- runFormPost projectInviteCompForm
-    defaultLayout $(widgetFile "project/component-new")
-
 postProjectInviteCompR :: KeyHashid Project -> Handler Html
 postProjectInviteCompR projectHash = do
     projectID <- decodeKeyHashid404 projectHash
@@ -575,27 +574,22 @@ postProjectInviteCompR projectHash = do
     result <- runExceptT $ do
         (maybeSummary, audience, invite) <-
             C.inviteComponent personID projectID uComp
-        grantID <- do
+        cap <- do
             maybeItem <- lift $ runDB $ do
                 resourceID <- projectResource <$> get404 projectID
-                getGrant resourceID personID
-            fromMaybeE maybeItem "You need to be a collaborator in the Project to invite people"
-        grantHash <- encodeKeyHashid grantID
-        let uCap = encodeRouteHome $ ProjectOutboxItemR projectHash grantHash
+                getCapability personID (Left resourceID) AP.RoleAdmin
+            fromMaybeE maybeItem "You need to be have Admin access to the Project to invite components"
+        uCap <- lift $ renderActivityURI cap
         (localRecips, remoteRecips, fwdHosts, action) <-
             C.makeServerInput (Just uCap) maybeSummary audience $ AP.InviteActivity invite
-        let cap =
-                Left (LocalActorProject projectID, LocalActorProject projectHash, grantID)
+        let cap' = first (\ (la, i) -> (la, error "lah", i)) cap
         handleViaActor
-            personID (Just cap) localRecips remoteRecips fwdHosts action
+            personID (Just cap') localRecips remoteRecips fwdHosts action
 
     case result of
-        Left e -> do
-            setMessage $ toHtml e
-            redirect $ ProjectInviteCompR projectHash
-        Right inviteID -> do
-            setMessage "Invite sent"
-            redirect $ ProjectComponentsR projectHash
+        Left e -> setMessage $ toHtml e
+        Right inviteID -> setMessage "Invite sent"
+    redirect $ ProjectComponentsR projectHash
 
 getProjectChildrenR :: KeyHashid Project -> Handler TypedContent
 getProjectChildrenR projectHash = do
diff --git a/src/Vervis/Widget/Person.hs b/src/Vervis/Widget/Person.hs
index a3dbbff..e56a0d5 100644
--- a/src/Vervis/Widget/Person.hs
+++ b/src/Vervis/Widget/Person.hs
@@ -130,7 +130,7 @@ followW' (Right actorID) = do
                 [whamlet|
                     <button type="button" disabled>
                       Following
-                      ^{buttonW POST "Unfollow" (UnfollowRemoteR actorID)}
+                    ^{buttonW POST "Unfollow" (UnfollowRemoteR actorID)}
                 |]
             else if alreadyRequest
             then
@@ -142,7 +142,7 @@ followW' (Right actorID) = do
                 [whamlet|
                     <button type="button" disabled>
                       Not following
-                      ^{buttonW POST "Follow" (FollowRemoteR actorID)}
+                    ^{buttonW POST "Follow" (FollowRemoteR actorID)}
                 |]
 
 personNavW :: Entity Person -> Widget
diff --git a/templates/project/component-new.hamlet b/templates/project/component-new.hamlet
deleted file mode 100644
index 47e4c9f..0000000
--- a/templates/project/component-new.hamlet
+++ /dev/null
@@ -1,18 +0,0 @@
-$# This file is part of Vervis.
-$#
-$# Written in 2016, 2023 by fr33domlover <fr33domlover@riseup.net>.
-$#
-$# ♡ Copying is an act of love. Please copy, reuse and share.
-$#
-$# The author(s) have dedicated all copyright and related and neighboring
-$# rights to this software to the public domain worldwide. This software is
-$# distributed without any warranty.
-$#
-$# You should have received a copy of the CC0 Public Domain Dedication along
-$# with this software. If not, see
-$# <http://creativecommons.org/publicdomain/zero/1.0/>.
-
-<form method=POST action=@{ProjectInviteCompR projectHash} enctype=#{enctype}>
-  ^{widget}
-  <div class="submit">
-    <input type="submit">
diff --git a/templates/project/components.hamlet b/templates/project/components.hamlet
index 28483e6..1242d48 100644
--- a/templates/project/components.hamlet
+++ b/templates/project/components.hamlet
@@ -1,6 +1,7 @@
 $# This file is part of Vervis.
 $#
-$# Written in 2016, 2019, 2022, 2023 by fr33domlover <fr33domlover@riseup.net>.
+$# Written in 2016, 2019, 2022, 2023, 2024
+$# by fr33domlover <fr33domlover@riseup.net>.
 $#
 $# ♡ Copying is an act of love. Please copy, reuse and share.
 $#
@@ -28,6 +29,12 @@ $# <http://creativecommons.org/publicdomain/zero/1.0/>.
       <td>#{showDate since}
 $#    <td>^{buttonW POST "Remove" (ProjectRemoveR projectHash ctID)}
 
+$if haveAdmin
+  <p>Invite a component:
+  <form method=POST action=@{ProjectInviteCompR projectHash} enctype=#{enctypeIC}>
+    ^{widgetIC}
+    <input type="submit">
+
 <h2>Component requests in progress
 
 <table>
@@ -38,5 +45,3 @@ $#    <td>^{buttonW POST "Remove" (ProjectRemoveR projectHash ctID)}
     <tr>
       <td>#{show role}
       <td>^{componentLinkFedW comp}
-
-<a href=@{ProjectInviteCompR projectHash}>Invite…
diff --git a/th/routes b/th/routes
index f39a92b..8de2e1e 100644
--- a/th/routes
+++ b/th/routes
@@ -359,7 +359,7 @@
 /projects/#ProjectKeyHashid/components                   ProjectComponentsR GET
 /projects/#ProjectKeyHashid/collabs/#CollabEnableKeyHashid/live ProjectCollabLiveR    GET
 
-/projects/#ProjectKeyHashid/invite-component             ProjectInviteCompR     GET POST
+/projects/#ProjectKeyHashid/invite-component             ProjectInviteCompR     POST
 
 /projects/#ProjectKeyHashid/children ProjectChildrenR GET
 /projects/#ProjectKeyHashid/parents  ProjectParentsR  GET