Currently the SSH and GPG keys are hardcoded. In a refactoring those
will be passed down as prop to the component. But I would need to query
Vervis to receive the real keys. Likewise I am not talking to Vervis
when updating (remove, add) a key.
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
This is not interacting with Vervis at this point in time.
I clarified that changes should be persisted on moving away from a view.
I'm going to implement that once I have all views in place.
On top of that, persisting changes to Vervis requires me to study the
now documented Vervis API in more detail. I'm going to postpone this for
now but will revisit it in a few weeks.
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
This is now showing the MainMenu on the profile page which in turn
pulls in the Settings modal.
I wasn't able to register the modal on Storybook yet, which means
that there won't be any on the Profile template or page story.
The implementation in Skeleton is causing some accessibility
warnings. However, since there next version is taking a radical
different approach I'm inclined to let it be for now. We should
document it somewhere, I guess.
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
I realised that I must not show the sidebar everywhere. So to not move
code around I extracted it into its own component. This one is not
matching the design (because of the links etc.) but is a step in the
direction.
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
This is in need of at least one refactoring. Skeleton is redesigning
the AppRail we are using here. The layout is hard to style.
This implementation interacts with a drawer, but it will likely be
dropped in the final version.
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
This is the top part of the main menu which includes the Avatar overlay.
I'm not quite sure how to label each part.
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
I'm going to break up my MainMenu into smaller components, starting with
the OverlayAvatar. Testing it taught me how to handle stores in Vitest.
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
This allows for proper testing and documentation in Storybook.
I also moved the image into its own component. This required me to
adjust the vitest.config.ts slightly because it wasn't finding the image
during tests.
Since components are fully translatable, this means we have new keys
now.
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
This markup was commented. In case we ever need it, git will have it
stored in the repo history.
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
By moving the fallback text into its own component I was able to move
the list element into the History molecule. Its API has changed
accordingly. I have written tests to prevent regressions.
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
I checked PenPot again and noticed that there is spacing between each
entry. I could have changed the lists to a different element but that
would be another refactoring just to use Flexbox for styling. Instead I
went with some margin.
If I want to use Flexbox I should first move the fallback from Profile
into this component and turn it into another Atom.
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
This way the History molecule is only concerned with mapping the list of
commits to the appropriate structure and iterating over it. The markup
is deferred to separate components now.
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
In order to reduce the complexity of a component I broke out the body
part of a commit into its own component.
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
I was reading warnings during the execution of tests and fixed them for
ImportProject templates and pages.
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
This allows for easier testing. The component is still complex, so it
requires more refactoring into smaller parts. But I can now safely do
that since I have specified the expected behaviour with a test.
I already discovered a bug while writing the tests: I want to group by
date irrespective of the timestamp. Therefore I need to parse the date
from the ISO timestamp of a commit.
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
Yes, this means nested looping. But it also allows me to separate the
commits into a shape I need. I feel like this should not happen in
Vervis as it is something I as a consument of the data need.
I could have done this inside of the template but it feels ugly.
The main drawback I have with the current approach is that Svelte is not
capable of looping over objects so I have to turn that into a list of
nested Arrays. I might have done that in the function already but it is
easier to look up keys on an Object that to sift through Arrays.
The current implementation works. The next step is to extract it into a
component, test it and then I can refactor further.
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
I also learned how to pluralise. I'm curious whether Weblate can handle
that. It follows ICU standard at least.
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
I had to hardcode the path to the commits because it is not a property
on the repository object. There are empty repositories, which I handle
as well.
Next step is displaying them in the Activities.
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
When looking at the Memorandum of Understanding I realised that I should
display repositories instead of projects. So I reused the new component
to do just that.
I could not use a list here, because I need spacing between the
elements. If I were to apply Flexbox to lists it would change their
semantics. But plain divs lack all kinds of semantics. I went with the
next best thing and picked a section as container.
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
During testing I realised that the buttons are not accessible.
While I was adding text I also ensured that it can be translated.
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
I feel like Fork-Star-Watch is a pattern that we will reuse.
Therefore the new component is a molecule.
I also look up the person as collaborator which works for the small test
set I used during development but will likely break in production for
others. That's good. It will show me more information I need to design
the component better. I lack that at the moment.
Ideally I would use a database here, but before I can set up one I
better understand the data model.
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
Since I learned that I can't use TypeScript in conjunction with
Storybook, I have no more use for this file.
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
This shows the avatar fallback because I have no way to know the avatar
in Vervis at the moment.
Also no username associated, that is, I would need to look it up. Should
work for getting the idea at the moment.
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
These are not implemented everywhere so I have to handle errors here.
But for what we want to build right now (projects overview) they are.
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
This comes close to the design specification already. But I lack some
information in the Vervis responses.
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
I discovered that Vervis understands Content Negotiation.
That is, once I figure out my peopleId I can navigate to the respective
paths and resceive JSON that is equal to the prettyjson'ed HTML views I
can see in the web browser.
I don't find everything I would like to have. Therefore I'm writing the
results to a file for now and read it in the profile so I can talk to
our designer how to move on with what we have right now.
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
Now it is more obvious that I only handle the homepage from the library
and have the login as an implementation detail.
Once I figure out how to talk to Vervis' API I can drop Cheerio and use
ReST instead.
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
The file has grown and I want to break it apart into smaller files.
Therefore I rename the file in the first step and adjust the import
paths.
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
These locales were created using Weblate. Therefore the PR introducing
them was unaware of REUSE. I created the files manually.
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
