forge/Anvil
1
0
Fork 0
Code Pull requests Activity

feat: add Appearance panel to Settings modal

Browse source 
This features two knobs: theming and indent.
I was curious whether I could actually hand the theme switching to the
parent, so I created an event dispatcher for it.

It works! But I had to hack the Svelte component a little.
I also need to sync it two the theme switcher in the popup and go over
every component that is focused on light mode only at the moment. To
limit the work I will constraint myself to the Profile page here. If the
theme is meant to apply to other pages as well, we will need to persist
the setting. That means a database in Anvil, I guess. I'm not willing to
take that step right now. It must come at some point (e.g. when talking
to Vervis to actually inform about changes made in Anvil).

Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
This commit is contained in:
André Jaenisch 2024-08-08 10:29:31 +02:00
parent b5fed52bc5
commit 5af877bcaa
No known key found for this signature in database
GPG key ID: 5A668E771F1ED854
11 changed files with 514 additions and 262 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
package-lock.json generated
View file

@ -1,12 +1,12 @@
{
"name": "anvil",
"version": "0.0.12",
"version": "0.0.13",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "anvil",
"version": "0.0.12",
"version": "0.0.13",
"dependencies": {
"@floating-ui/dom": "1.6.8",
"@fontsource/spline-sans-mono": "5.0.20",

2
package.json
View file

@ -1,6 +1,6 @@
{
"name": "anvil",
"version": "0.0.12",
"version": "0.0.13",
"private": true,
"scripts": {
"dev": "vite dev",

21
src/lib/components/molecules/Settings.svelte
View file

@ -13,15 +13,34 @@ You should have received a copy of the GNU Affero General Public License along w
<script>
import SettingsAccount from './SettingsAccount.svelte';
import SettingsAppearance from './SettingsAppearance.svelte';
import SettingsKeys from './SettingsKeys.svelte';
import SettingsSidebar from '../atoms/SettingsSidebar.svelte';
import SettingsProfile from './SettingsProfile.svelte';
let activeSetting = 'profile';
let activeTheme = 'auto';
function onTileChanged(ev) {
activeSetting = ev.detail;
}
function onThemeSwitched(ev) {
activeTheme = ev.detail;
// This is a hack.
// Skeleton relies on Cookies and a hook:
// https://github.com/skeletonlabs/skeleton/blob/%40skeletonlabs/skeleton%402.10.2/sites/skeleton.dev/src/hooks.server.ts#L16
// Svelte itself features a svelte:document special element that must
// only be used at the top level - except SvelteKit has app.html
// as a static file :[]
// Ideas welcome!
if (window?.document?.documentElement) {
window.document.documentElement.classList.remove('auto');
window.document.documentElement.classList.remove('dark');
window.document.documentElement.classList.remove('light');
window.document.documentElement.classList.add(activeTheme);
}
}
</script>
<div class="flex bg-surface-50 min-h-[900px]">
@ -33,5 +52,7 @@ You should have received a copy of the GNU Affero General Public License along w
<SettingsAccount />
{:else if activeSetting === 'ssh_gpg_keys'}
<SettingsKeys />
{:else if activeSetting === 'appearance'}
<SettingsAppearance on:switch-theme={onThemeSwitched} />
{/if}
</div>

68
src/lib/components/molecules/SettingsAppearance.svelte Normal file
View file

@ -0,0 +1,68 @@
<!--
SettingsAppearance molecule.
Copyright (C) 2024 André Jaenisch
SPDX-FileCopyrightText: 2024 André Jaenisch
SPDX-License-Identifier: AGPL-3.0-or-later
This program is free software: you can redistribute it and/or modify it under the terms of the GNU Affero General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version.
This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Affero General Public License for more details.
You should have received a copy of the GNU Affero General Public License along with this program. If not, see <http://www.gnu.org/licenses/>.
-->
<script>
import { createEventDispatcher } from 'svelte';
import { _ } from 'svelte-i18n';
const dispatcher = createEventDispatcher();
function onThemeSwitched(ev) {
dispatcher('switch-theme', ev.target.value);
}
</script>
<div class="flex flex-col flex-1 gap-6 pe-8 pb-8 ps-8 pt-20 bg-surface-100-800-token">
<div class="text-surface-500-300-token text-xl font-semibold">
{$_('settings.appearance.headline')}
</div>
<div class="flex flex-col gap-2">
<div class="text-surface-500-300-token font-semibold py-1">
{$_('settings.appearance.theme.headline')}
</div>
<div class="flex gap-8">
<label class="label flex items-center space-x-2">
<input type="radio" class="me-2" name="theme" value="light" on:change={onThemeSwitched} />
{$_('settings.appearance.theme.light')}
</label>
<label class="label flex items-center space-x-2">
<input type="radio" class="me-2" name="theme" value="dark" on:change={onThemeSwitched} />
{$_('settings.appearance.theme.dark')}
</label>
<label class="label flex items-center space-x-2">
<input
type="radio"
class="me-2"
name="theme"
value="auto"
checked
on:change={onThemeSwitched}
/>
{$_('settings.appearance.theme.auto')}
</label>
</div>
</div>
<div class="flex flex-col gap-2">
<div class="text-surface-500-300-token font-semibold py-1">
{$_('settings.appearance.tab_indent.headline')}
</div>
<p class="text-sm">{$_('settings.appearance.tab_indent.intro')}</p>
<input
type="text"
class="input bg-white text-center text-surface-500-300-token max-w-16"
name="tab_indent"
value="4"
/>
</div>
</div>

13
src/lib/i18n/locales/bg.json
View file

@ -192,7 +192,18 @@
}
},
"appearance": {
"label": ""
"headline": "",
"label": "",
"tab_indent": {
"headline": "",
"intro": ""
},
"theme": {
"auto": "",
"dark": "",
"headline": "",
"light": ""
}
},
"notifications": {
"label": ""

521
src/lib/i18n/locales/de.json
View file

@ -1,257 +1,268 @@
{
"overlay": {
"avatar": {
"about_anvil": "Über Anvil",
"dark_mode": "",
"profile": "",
"settings": "",
"sign_out": ""
}
},
"page": {
"import_project": {
"form": {
"avatar": "Avatar",
"components": "Komponenten",
"fields": {
"avatar": {
"label": "Bild hochladen"
},
"description": {
"label": "Beschreibung",
"placeholder": "Beschreibe das Projekt in unter 100 Zeichen..."
},
"issues": {
"label": "Issues"
},
"name": {
"error": "Dieses Feld ist erforderlich",
"label": "Name",
"placeholder": "Name des Projekts..."
},
"pr": {
"label": "Pullrequest"
},
"repository": {
"hint": "optional: von Git-Repository importieren",
"label": "Repository",
"placeholder": "URL des Git-Repositorys"
}
},
"submit": "Projekt erstellen"
},
"heading": "Projekt erstellen",
"intro": "Neues F2-Projekt zu Anvil hinzufügen."
},
"login": {
"form": {
"fields": {
"account": {
"label": "Accountname"
},
"passphrase": {
"label": "Passwort",
"placeholder": "Passwort"
},
"server": {
"label": "F2-Server"
}
},
"reset": "Passwort zurücksetzen",
"submit": "Einloggen",
"validation": {
"incorrect": "Accountname oder Kennwort sind falsch.",
"missing": "Das Account-Feld ist verbindlich."
}
},
"heading": "Einloggen",
"intro": "Die Einwahldaten ausfüllen um Anvil mit deinem F2-Account zu benutzen."
},
"profile": {
"activities": {
"block_or_report": "{blockElementOpen}blockieren{blockElementClose} oder {reportElementOpen}melden{reportElementClose}",
"like": "Gefällt mir"
},
"heading": "Profil für",
"history": {
"activities": {
"commits": {
"actions": {
"browse": "",
"copy": ""
},
"number": "",
"relative_time": ""
},
"setup": {
"description": "Das F2-Konto @{username}@{instance} wurde erfolgreich innerhalb von {created_with} erstellt",
"summary": "Kontoeinstellungen"
}
},
"heading": "Aktivitäten"
},
"menu": {
"actions": {
"fork": "",
"star": "",
"watch": ""
},
"buttons": {
"avatar": "",
"issues": "",
"notifications": "",
"prs": ""
},
"details": {
"branches": "",
"commits": "",
"files": "",
"issues": "",
"merge_requests": "",
"moderation": "",
"overview": "",
"people": "",
"repository": "",
"roles": "",
"tags": ""
}
},
"projects": {
"actions": {
"fork": "Fork",
"star": "Favorisieren",
"watch": "Beobachten"
},
"add_or_import": "{addElementOpen}Ein Projekt hinzufügen{addElementClose} oder {importElementOpen}Ein Projekt importieren{importElementClose}.",
"empty": "Bisher keine Projekte hinzugefügt.",
"heading": "Projekte"
},
"repositories": {
"heading": ""
}
},
"projects": {
"file_table": {
"updated": "Aktualisiert: {relativeTime}"
},
"form": {
"fields": {
"more_filters": {
"submit": "Weitere Filter"
},
"projects": {
"submit": "Meine Projekte"
},
"search": {
"placeholder": "Suchen oder filtern",
"submit": "Absenden"
},
"starred": {
"submit": "Favorisiert"
}
}
},
"nav": {
"next": "Weiter",
"previous": "Zurück"
},
"table": {
"heading": {
"last_updated": "Letzte Aktualisierung",
"name": "Name"
}
}
},
"welcome": {
"create": "",
"intro": "",
"headline": "Willkommen bei Anvil",
"login": "",
"logo": {
"alt": ""
},
"reset": ""
}
},
"settings": {
"headline": "",
"account": {
"delete": "",
"f2": {
"label": "",
"placeholder": ""
},
"headline": "",
"label": "",
"password": {
"label": "",
"reset": ""
},
"verification": {
"label": ""
}
},
"appearance": {
"label": ""
},
"notifications": {
"label": ""
},
"profile": {
"avatar": {
"headline": "",
"remove": "",
"upload": ""
},
"bio": {
"label": "",
"placeholder": ""
},
"extra": {
"content": {
"placeholder": ""
},
"headline": "",
"hint": "",
"label": {
"placeholder": ""
}
},
"headline": "",
"label": "",
"name": {
"label": "",
"placeholder": ""
},
"pronouns": {
"label": ""
}
},
"ssh_gpg_keys": {
"gpg": {
"add": "",
"headline": "",
"key": {
"placeholder": ""
},
"remove": "",
"title": {
"placeholder": ""
}
},
"headline": "",
"label": "",
"ssh": {
"add": "",
"headline": "",
"key": {
"placeholder": ""
},
"remove": "",
"title": {
"placeholder": ""
}
}
}
}
"overlay": {
"avatar": {
"about_anvil": "Über Anvil",
"dark_mode": "",
"profile": "",
"settings": "",
"sign_out": ""
}
},
"page": {
"import_project": {
"form": {
"avatar": "Avatar",
"components": "Komponenten",
"fields": {
"avatar": {
"label": "Bild hochladen"
},
"description": {
"label": "Beschreibung",
"placeholder": "Beschreibe das Projekt in unter 100 Zeichen..."
},
"issues": {
"label": "Issues"
},
"name": {
"error": "Dieses Feld ist erforderlich",
"label": "Name",
"placeholder": "Name des Projekts..."
},
"pr": {
"label": "Pullrequest"
},
"repository": {
"hint": "optional: von Git-Repository importieren",
"label": "Repository",
"placeholder": "URL des Git-Repositorys"
}
},
"submit": "Projekt erstellen"
},
"heading": "Projekt erstellen",
"intro": "Neues F2-Projekt zu Anvil hinzufügen."
},
"login": {
"form": {
"fields": {
"account": {
"label": "Accountname"
},
"passphrase": {
"label": "Passwort",
"placeholder": "Passwort"
},
"server": {
"label": "F2-Server"
}
},
"reset": "Passwort zurücksetzen",
"submit": "Einloggen",
"validation": {
"incorrect": "Accountname oder Kennwort sind falsch.",
"missing": "Das Account-Feld ist verbindlich."
}
},
"heading": "Einloggen",
"intro": "Die Einwahldaten ausfüllen um Anvil mit deinem F2-Account zu benutzen."
},
"profile": {
"activities": {
"block_or_report": "{blockElementOpen}blockieren{blockElementClose} oder {reportElementOpen}melden{reportElementClose}",
"like": "Gefällt mir"
},
"heading": "Profil für",
"history": {
"activities": {
"commits": {
"actions": {
"browse": "",
"copy": ""
},
"number": "",
"relative_time": ""
},
"setup": {
"description": "Das F2-Konto @{username}@{instance} wurde erfolgreich innerhalb von {created_with} erstellt",
"summary": "Kontoeinstellungen"
}
},
"heading": "Aktivitäten"
},
"menu": {
"actions": {
"fork": "",
"star": "",
"watch": ""
},
"buttons": {
"avatar": "",
"issues": "",
"notifications": "",
"prs": ""
},
"details": {
"branches": "",
"commits": "",
"files": "",
"issues": "",
"merge_requests": "",
"moderation": "",
"overview": "",
"people": "",
"repository": "",
"roles": "",
"tags": ""
}
},
"projects": {
"actions": {
"fork": "Fork",
"star": "Favorisieren",
"watch": "Beobachten"
},
"add_or_import": "{addElementOpen}Ein Projekt hinzufügen{addElementClose} oder {importElementOpen}Ein Projekt importieren{importElementClose}.",
"empty": "Bisher keine Projekte hinzugefügt.",
"heading": "Projekte"
},
"repositories": {
"heading": ""
}
},
"projects": {
"file_table": {
"updated": "Aktualisiert: {relativeTime}"
},
"form": {
"fields": {
"more_filters": {
"submit": "Weitere Filter"
},
"projects": {
"submit": "Meine Projekte"
},
"search": {
"placeholder": "Suchen oder filtern",
"submit": "Absenden"
},
"starred": {
"submit": "Favorisiert"
}
}
},
"nav": {
"next": "Weiter",
"previous": "Zurück"
},
"table": {
"heading": {
"last_updated": "Letzte Aktualisierung",
"name": "Name"
}
}
},
"welcome": {
"create": "",
"intro": "",
"headline": "Willkommen bei Anvil",
"login": "",
"logo": {
"alt": ""
},
"reset": ""
}
},
"settings": {
"headline": "",
"account": {
"delete": "",
"f2": {
"label": "",
"placeholder": ""
},
"headline": "",
"label": "",
"password": {
"label": "",
"reset": ""
},
"verification": {
"label": ""
}
},
"appearance": {
"headline": "",
"label": "",
"tab_indent": {
"headline": "",
"intro": ""
},
"theme": {
"auto": "",
"dark": "",
"headline": "",
"light": ""
}
},
"notifications": {
"label": ""
},
"profile": {
"avatar": {
"headline": "",
"remove": "",
"upload": ""
},
"bio": {
"label": "",
"placeholder": ""
},
"extra": {
"content": {
"placeholder": ""
},
"headline": "",
"hint": "",
"label": {
"placeholder": ""
}
},
"headline": "",
"label": "",
"name": {
"label": "",
"placeholder": ""
},
"pronouns": {
"label": ""
}
},
"ssh_gpg_keys": {
"gpg": {
"add": "",
"headline": "",
"key": {
"placeholder": ""
},
"remove": "",
"title": {
"placeholder": ""
}
},
"headline": "",
"label": "",
"ssh": {
"add": "",
"headline": "",
"key": {
"placeholder": ""
},
"remove": "",
"title": {
"placeholder": ""
}
}
}
}
}

13
src/lib/i18n/locales/en.json
View file

@ -192,7 +192,18 @@
}
},
"appearance": {
"label": "Appearance"
"headline": "Appearance",
"label": "Appearance",
"tab_indent": {
"headline": "Tab indenting",
"intro": "Number of spaces per tab in code view."
},
"theme": {
"auto": "Auto",
"dark": "Dark",
"headline": "Theme",
"light": "Light"
}
},
"notifications": {
"label": "Notifications"

13
src/lib/i18n/locales/he.json
View file

@ -192,7 +192,18 @@
}
},
"appearance": {
"label": ""
"headline": "",
"label": "",
"tab_indent": {
"headline": "",
"intro": ""
},
"theme": {
"auto": "",
"dark": "",
"headline": "",
"light": ""
}
},
"notifications": {
"label": ""

13
src/lib/i18n/locales/pl.json
View file

@ -192,7 +192,18 @@
}
},
"appearance": {
"label": ""
"headline": "",
"label": "",
"tab_indent": {
"headline": "",
"intro": ""
},
"theme": {
"auto": "",
"dark": "",
"headline": "",
"light": ""
}
},
"notifications": {
"label": ""

26
stories/molecules/SettingsAppearance.stories.ts Normal file
View file

@ -0,0 +1,26 @@
/* Stories for SettingsAppearance molecule.
* Copyright (C) 2024 André Jaenisch
* SPDX-FileCopyrightText: 2024 André Jaenisch
* SPDX-License-Identifier: AGPL-3.0-or-later
*
* This program is free software: you can redistribute it and/or modify it under the terms of the GNU Affero General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
import type { Meta, StoryObj } from '@storybook/svelte';
import SettingsAppearance from '$lib/components/molecules/SettingsAppearance.svelte';
const meta = {
title: 'Molecules/SettingsAppearance',
component: SettingsAppearance,
tags: ['autodocs']
} satisfies Meta<SettingsAppearance>;
export default meta;
type Story = StoryObj<typeof meta>;
export const Plain: Story = {};

82
tests/components/molecules/SettingsAppearance.test.ts Normal file
View file

@ -0,0 +1,82 @@
/* Component test for SettingsAppearance molecule.
* Copyright (C) 2024 André Jaenisch
* SPDX-FileCopyrightText: 2024 André Jaenisch
* SPDX-License-Identifier: AGPL-3.0-or-later
*
* This program is free software: you can redistribute it and/or modify it under the terms of the GNU Affero General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
import '@testing-library/jest-dom';
import { render, screen } from '@testing-library/svelte';
import { init, locale, register } from 'svelte-i18n';
import SettingsAppearance from '../../../src/lib/components/molecules/SettingsAppearance.svelte';
import enMessages from '../../../src/lib/i18n/locales/en.json';
describe('SettingsAppearance.svelte', () => {
beforeEach(() => {
register('en', () => import('../../../src/lib/i18n/locales/en.json'));
init({ fallbackLocale: 'en', initialLocale: 'en' });
locale.set('en');
});
it('should mount', () => {
// Arrange
// Nothing to prepare
// Act
const { container } = render(SettingsAppearance);
// Assert
expect(container).toBeTruthy();
});
it('should have a radio group for themes', () => {
// Arrange
// Nothing to prepare
// Act
render(SettingsAppearance);
// Assert
expect(screen.getByLabelText(enMessages.settings.appearance.theme.light)).toBeInTheDocument();
expect(screen.getByLabelText(enMessages.settings.appearance.theme.dark)).toBeInTheDocument();
expect(screen.getByLabelText(enMessages.settings.appearance.theme.auto)).toBeInTheDocument();
});
describe('when clicking a theme', () => {
it('should dispatch a switch-theme event', () => {
// Arrange
const listener = vi.fn();
// Act
const { component } = render(SettingsAppearance);
component.$on('switch-theme', listener);
const darkTheme = screen.getByLabelText(enMessages.settings.appearance.theme.dark);
darkTheme.click();
const ev = new CustomEvent({ detail: 'dark' });
// Assert
expect(listener).toHaveBeenCalledOnce();
expect(listener).toHaveBeenCalledWith(ev);
});
});
// TODO: Mark up proper label and input
it.skip('should have a tab indent input', () => {
// Arrange
// Nothing to prepare
// Act
render(SettingsAppearance);
// Assert
expect(
screen.getByPlaceholderText(enMessages.settings.appearance.tab_indent.label)
).toBeInTheDocument();
});
});